Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new test db for unit tests #63

Merged
merged 1 commit into from
Jan 14, 2024
Merged

added new test db for unit tests #63

merged 1 commit into from
Jan 14, 2024

Conversation

MadelaineJ
Copy link
Collaborator

Problem
Unit tests currently use the development database

Solution

  • updated database.py to create new database
  • updated dockerfile to pass new db name to unit Tests
  • updated README for running tests locally
  • also updated seeder reqs to work on macos

Ticket URL
https://mediform.atlassian.net/browse/MEDI-16

Documentation
NA

Tests Run
Tested that unit tests now use the test db

Problem
Unit tests currently use the development database

Solution
- updated database.py to create new database
- updated dockerfile to pass new db name to unit Tests
- updated README for running tests locally
- also updated seeder reqs to work on macos

Ticket URL
https://mediform.atlassian.net/browse/MEDI-16

Documentation
NA

Tests Run
Tested that unit tests now use the test db
@MadelaineJ MadelaineJ requested a review from critch646 January 14, 2024 01:30
Copy link
Collaborator

@critch646 critch646 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

There really isn't anything I can add to this.

@MadelaineJ MadelaineJ merged commit edf12ee into main Jan 14, 2024
1 check passed
@MadelaineJ MadelaineJ deleted the madelaine branch January 14, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants