Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-binding let breaking build #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

piotr-yuxuan
Copy link

$ cargo build --release
   Compiling keylightd v1.1.0 (/home/caocoa/Dropbox/Pierre/src/github.com/jonas-schievink/keylightd)
error: non-binding let on a synchronization lock
   --> src/main.rs:134:14
    |
134 |         let (_, result) = act
    |              ^ this lock is not assigned to a binding and is immediately dropped
    |
    = help: consider immediately dropping the value using `drop(..)` after the `let` statement
    = note: `#[deny(let_underscore_lock)]` on by default
help: consider binding to an unused variable to avoid immediately dropping the value
    |
134 |         let (_unused, result) = act
    |              ~~~~~~~

error: could not compile `keylightd` (bin "keylightd") due to 1 previous error

```
$ cargo build --release
   Compiling keylightd v1.1.0 (/home/caocoa/Dropbox/Pierre/src/github.com/jonas-schievink/keylightd)
error: non-binding let on a synchronization lock
   --> src/main.rs:134:14
    |
134 |         let (_, result) = act
    |              ^ this lock is not assigned to a binding and is immediately dropped
    |
    = help: consider immediately dropping the value using `drop(..)` after the `let` statement
    = note: `#[deny(let_underscore_lock)]` on by default
help: consider binding to an unused variable to avoid immediately dropping the value
    |
134 |         let (_unused, result) = act
    |              ~~~~~~~

error: could not compile `keylightd` (bin "keylightd") due to 1 previous error
```
@tgrushka
Copy link

Yep, this fixes it for me.

@andypiper
Copy link

thanks, I am seeing this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants