Skip to content

Commit

Permalink
Silence :wrong-arity false positives for honeysql for now
Browse files Browse the repository at this point in the history
See #399
  • Loading branch information
vemv committed Aug 20, 2021
1 parent 5901543 commit 100f667
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 1 deletion.
7 changes: 6 additions & 1 deletion changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,19 @@

#### New

* Implement ability to omit a specific linter `:kind`
* Implement ability to omit a specific linter `:kind`.
* Closes https://github.com/jonase/eastwood/issues/387
* [Documentation](https://github.com/jonase/eastwood#ignoring-linter-sub-kinds)
* Now the `:second-arg-is-not-string` sub-kind for the `:suspicious-test` is disabled by default.
* Rationale: https://github.com/jonase/eastwood/issues/387
* You can re-enable it by passing `:exclude-linters #{}`
* [Learn more about sub-kind silencing](https://github.com/jonase/eastwood#ignoring-linter-sub-kinds)

#### Bugfixes

* Silence `:wrong-arity` false positives for honeysql the time being.
* Part of https://github.com/jonase/eastwood/issues/399

## Changes from 0.9.4 to 0.9.6

#### Bugfixes
Expand Down
42 changes: 42 additions & 0 deletions resource/eastwood/config/third-party-libs.clj
Original file line number Diff line number Diff line change
Expand Up @@ -345,3 +345,45 @@
{:linter :constant-test
:if-inside-macroexpansion-of #{'spec-tools.core/spec
'borkdude.dynaload/dynaload}})

(doseq [s '[honey.sql.helpers/add-index
honey.sql.helpers/alter-table
honey.sql.helpers/bulk-collect-into
honey.sql.helpers/clause-or-expression
honey.sql.helpers/create-extension
honey.sql.helpers/create-materialized-view
honey.sql.helpers/create-table
honey.sql.helpers/create-table-as
honey.sql.helpers/create-view
honey.sql.helpers/delete
honey.sql.helpers/delete-from
honey.sql.helpers/do-nothing
honey.sql.helpers/do-update-set
honey.sql.helpers/drop-column
honey.sql.helpers/fetch
honey.sql.helpers/filter
honey.sql.helpers/for
honey.sql.helpers/insert-into
honey.sql.helpers/into
honey.sql.helpers/limit
honey.sql.helpers/lock
honey.sql.helpers/offset
honey.sql.helpers/on-conflict
honey.sql.helpers/on-constraint
honey.sql.helpers/on-duplicate-key-update
honey.sql.helpers/refresh-materialized-view
honey.sql.helpers/rename-column
honey.sql.helpers/rename-table
honey.sql.helpers/select-distinct-on
honey.sql.helpers/set
honey.sql.helpers/truncate
honey.sql.helpers/update
honey.sql.helpers/values
honey.sql.helpers/with-columns
honey.sql.helpers/with-data
honey.sql.helpers/within-group]]
(disable-warning
{:linter :wrong-arity
:function-symbol s
:arglists-for-linting '([& _])
:reason "Eastwood is currently unable to parse honeysql-style arglists, see https://github.com/jonase/eastwood/issues/399"}))

0 comments on commit 100f667

Please sign in to comment.