Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Hide matching pattern if algorithm is auto #248

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Hide matching pattern if algorithm is auto #248

merged 2 commits into from
Jan 2, 2021

Conversation

shamoon
Copy link
Contributor

@shamoon shamoon commented Jan 2, 2021

This PR fixes #164 as discussed in #212 (comment) , it hides the pattern field if algorithm is set to "auto"

@jonaswinkler One thing I noticed is that its hard to tell what the default is, in the list of tags/correspondents under 'Matching' it just shows - and when you edit one of those the menu option is "Any", but is it actually ( / should it be) "Auto"? LMK, obviously I can sort it out if its just kind of a UI quirk

Edit: I see in Django admin default is "Any", so perhaps Angular UI should show same?

@jonaswinkler
Copy link
Owner

jonaswinkler commented Jan 2, 2021

The matching algorithms don't do anything when the match is empty. That's why it shows up as "-" in the list. Except for Auto, which is always active.

I'd like to have an explicit matching algorithm field value for disabling matching eventually.

"Any" should be default.

"Auto" should NOT be default, since this doesn't work for all kinds of tags.

Also: "Case insensitive" does not apply to auto matching as well, please hide that!

@shamoon
Copy link
Contributor Author

shamoon commented Jan 2, 2021

Oh I didn’t realize much of that. Yea might be worth thinking about how to clarify.

I’ll fix the checkbox soon, sorry I didn’t notice that

@shamoon
Copy link
Contributor Author

shamoon commented Jan 2, 2021

Ok, checkbox hidden, should be all set

@jonaswinkler jonaswinkler merged commit 061dc04 into jonaswinkler:dev Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants