Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridworld constants and reward size fix #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

casper2002casper
Copy link

@casper2002casper casper2002casper commented Mar 2, 2022

Gridworld stores its constants as part of its environment instead of declaring them as constants, differing from other examples.
It also uses rewards in range [-10, 10] which creates two problems, first it overpowers the exploration term of the uct formula and secondly the value function of the SimpleNet network is limited by the tanh activation function to [-1, 1] so it's unable to output the required value functions.
Before
benchmark_reward
After
benchmark_reward

10% better reward for AZ, however the NN doesn't improve further as the max reward is reached after the second iteration.

@jonathan-laurent
Copy link
Owner

Thanks! Do you have any idea why the gap is wider between the neural network and AlphaZero in the second case?

@casper2002casper
Copy link
Author

I think because the NN doesn't get replaced as the AZ benchmark maxes out

@jonathan-laurent
Copy link
Owner

Got it. This makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants