Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script and files to remove "black" and "white" list #1

Open
joncojonathan opened this issue Oct 7, 2020 · 4 comments
Open
Labels

Comments

@joncojonathan
Copy link
Owner

In an effort to avoid causing offence, the terms "blacklist" and "whitelist" should be refactored out of the script.

  • Rename blacklist.txt and whitelist.txt to blocklist.txt and allowlist.txt
  • Edit the script to update references following the rename (above)
@abhishekpatel946
Copy link

hey, @joncojonathan
I'll change and make PR;s

@joncojonathan
Copy link
Owner Author

I've just noted that line 40 of script/PSLogonFailures.ps1 already declares a variable called $blocklist which the renamed file path variable (on line 31) will collide with. Suggest changing the file path variables to be called $allowListFile and $blockListFile.

@joncojonathan
Copy link
Owner Author

Just need to test the PR for this before I merge, but this looks good now.

@abhishekpatel946
Copy link

abhishekpatel946 commented Oct 9, 2020

okay!
I'll be tested on my side

I was noticed that your script is run only on Windows Server but I'm using Windows 10 Home edition. So how to test the changes I've created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants