Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist -> blocklist, whitelist -> allowlist #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

blacklist -> blocklist, whitelist -> allowlist #2

wants to merge 2 commits into from

Conversation

hsteinmueller
Copy link

#1

@joncojonathan
Copy link
Owner

I've just noted that line 40 of script/PSLogonFailures.ps1 already declares a variable called $blocklist which the renamed file path variable (on line 31) will collide with. Suggest changing the file path variables to be called $allowListFile and $blockListFile.

Are you able to update your commit please?

@hsteinmueller
Copy link
Author

I've just noted that line 40 of script/PSLogonFailures.ps1 already declares a variable called $blocklist which the renamed file path variable (on line 31) will collide with. Suggest changing the file path variables to be called $allowListFile and $blockListFile.

Are you able to update your commit please?

Well sorry I didn't see that. Should be fixed now.

@joncojonathan
Copy link
Owner

Nothing to apologise for @hsteinmueller, I should have noticed when I opened the issue. That's looking good. I'll need to test it but I can probably merge this.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants