Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an issue whereby files encoded with UTF8-BOM would cause imports to be skipped #122

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rikrak
Copy link

@rikrak rikrak commented Mar 1, 2024

see #121

When importing a file that is encoded as UTF8-BOM, the leading non-printing character is preserved in the buffer and written to the output. This causes subsequent SASS builds to fail. In addition, if the BOM encoded file has an @import on the first line it is missed by baka as it doesn't recognise <ZWNBSP>@import 'blah';

I've fixed this in rather a blunt way by using a find/replace. There may well be a better way of doing this with fs, but I'm not familiar with the world of js libs to know of a better way :-/

@rikrak
Copy link
Author

rikrak commented Mar 1, 2024

Oh, also. Had to force push my changes to GitHub as husky(?) was grumbling about CRLF in some of the .ts files. I hadn't made any changes in these files, so figured it was a pre-existing issue, or it was environmental :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant