ggbot #8
ggbot #8
Conversation
|
I haven't added any tests yet. |
| #' ggbot("blue points") | ||
| ggbot <- function(...) { | ||
|
|
||
| tokens <- unlist(strsplit(unlist(rlang::exprs(...)), " ")) |
There was a problem hiding this comment.
With multiple arguments, this mashes all the words together into one vector. Perhaps distinct string inputs should be considered separate commands? e.g. ggbot("rotate x axis", "remove y axis") is something that could supported, and the words in each of those commands would ideally be kept separate. Unless the idea is that there should only one command per ggbot call -- in which case combining all the words together makes sense.
There was a problem hiding this comment.
The use case I had in mind was either one whole command or a vector of words. The use case you suggest is probably much more likely though; I should iterate over the elements of ... and treat each one as a call to ggbot.
| if (length(detect_remove_cmds) > 0 && length(detect_funs) > 0) { | ||
|
|
||
| ## remove theme | ||
| if (detect_funs[1] == "theme") return(theme_void()) |
There was a problem hiding this comment.
if multiple "funs" are provided, maybe all should be removed? e.g. "remove legend x axis" should maybe remove both?
There was a problem hiding this comment.
Yes, that sounds reasonable. I went with just the first because I'm still thinking about contamination between requests, but I need to build some examples with multiple funs and see how that looks.
|
This is indeed a first start; if a proper lexer is the better way to go then I'm all for that. It looked like it wasn't too different from a bunch of |
|
By "start" I just meant we would want to add more commands as more functionality gets added to ggeasy 😄 I think the One advantage of |
Commands currently supported:
I also aligned the figures in the shortcuts vignette.