tests(feature-paths): fixed tests after change to allow absolute paths

chore(release): updated release and changelog
jonsamwell · May 25, 2021 · 8df7314 · 8df7314
1 parent ea39e76
commit 8df7314
Show file tree

Hide file tree

Showing 8 changed files with 66 additions and 21 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## [2.0.2] - 25/05/2021
+* Fix #45 executing feature files outside of the current working directory
+
 ## [2.0.1] - 02/05/2021
 
 * BREAKING CHANGE: `TestFailure` is no longer thrown when an `expect` fails. Instead, use `GherkinTestFailure` when catching errors (i.e. replace `on TestFailure catch` with `on GherkinTestFailure catch`) (#37).

diff --git a/example/report.json b/example/report.json
diff --git a/lib/src/configuration.dart b/lib/src/configuration.dart
@@ -2,13 +2,18 @@ import 'package:gherkin/src/io/feature_file_matcher.dart';
 import 'package:gherkin/src/io/io_feature_file_accessor.dart';
 import 'package:gherkin/src/io/feature_file_reader.dart';
 
-import '../gherkin.dart';
 import './gherkin/parameters/custom_parameter.dart';
 import './gherkin/steps/world.dart';
 import './hooks/hook.dart';
 import './reporters/reporter.dart';
 
 import 'gherkin/attachments/attachment_manager.dart';
+import 'gherkin/steps/step_definition.dart';
+import 'reporters/json/json_reporter.dart';
+import 'reporters/message_level.dart';
+import 'reporters/progress_reporter.dart';
+import 'reporters/stdout_reporter.dart';
+import 'reporters/test_run_summary_reporter.dart';
 
 typedef CreateWorld = Future<World> Function(TestConfiguration config);
 typedef CreateAttachmentManager = Future<AttachmentManager> Function(

diff --git a/lib/src/feature_file_runner.dart b/lib/src/feature_file_runner.dart
@@ -2,7 +2,6 @@ import 'dart:async';
 import 'package:gherkin/src/gherkin/runnables/scenario_type_enum.dart';
 import 'package:collection/collection.dart';
 
-import '../gherkin.dart';
 import './reporters/message_level.dart';
 import './hooks/hook.dart';
 import './reporters/reporter.dart';
@@ -20,6 +19,7 @@ import './gherkin/steps/step_run_result.dart';
 import './gherkin/steps/world.dart';
 import './reporters/messages.dart';
 import './gherkin/attachments/attachment_manager.dart';
+import 'gherkin/exceptions/gherkin_exception.dart';
 
 class FeatureFileRunner {
   final TestConfiguration _config;

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: gherkin
-version: 2.0.1
+version: 2.0.2
 description: A Gherkin parsers and runner for Dart which is very similar to Cucumber, it provides the base BDD functionality ready for use in platform specific implementations i.e. flutter/web
 homepage: https://github.com/jonsamwell/dart_gherkin
 

diff --git a/test/io/io_feature_file_accessor_gnu_test.dart b/test/io/io_feature_file_accessor_gnu_test.dart
@@ -4,6 +4,8 @@ import 'package:gherkin/gherkin.dart';
 import 'package:glob/glob.dart';
 import 'package:test/test.dart';
 
+import 'path_part_matcher.dart';
+
 void main() {
   group('Matcher', () {
     final indexer = IoFeatureFileAccessor();
@@ -12,7 +14,7 @@ void main() {
       test('lists all matching files', () async {
         expect(
           await indexer.listFiles(RegExp(r'test/test_resources/(.*).feature')),
-          containsAll([
+          PathPartMatcher([
             r'test/test_resources/a.feature',
             r'test/test_resources/subdir/b.feature',
             r'test/test_resources/subdir/c.feature',
@@ -24,7 +26,7 @@ void main() {
         expect(
           await indexer
               .listFiles(RegExp(r'test/test_resources/subdir/.*\.feature')),
-          containsAll([
+          PathPartMatcher([
             r'test/test_resources/subdir/b.feature',
             r'test/test_resources/subdir/c.feature',
           ]),
@@ -36,7 +38,7 @@ void main() {
       test('lists all matching files', () async {
         expect(
           await indexer.listFiles(Glob('test/test_resources/**.feature')),
-          containsAll([
+          PathPartMatcher([
             r'test/test_resources/a.feature',
             r'test/test_resources/subdir/b.feature',
             r'test/test_resources/subdir/c.feature',
@@ -47,9 +49,9 @@ void main() {
       test('list all matching file without subdirectories', () async {
         expect(
           await indexer.listFiles(Glob('test/test_resources/*.feature')),
-          [
+          PathPartMatcher([
             r'test/test_resources/a.feature',
-          ],
+          ]),
         );
       });
     });
@@ -58,9 +60,9 @@ void main() {
       test('lists one specified file', () async {
         expect(
           await indexer.listFiles(r'test/test_resources/a.feature'),
-          [
+          PathPartMatcher([
             r'test/test_resources/a.feature',
-          ],
+          ]),
         );
       });
     });

diff --git a/test/io/io_feature_file_accessor_windows_test.dart b/test/io/io_feature_file_accessor_windows_test.dart
@@ -4,6 +4,8 @@ import 'package:gherkin/gherkin.dart';
 import 'package:glob/glob.dart';
 import 'package:test/test.dart';
 
+import 'path_part_matcher.dart';
+
 void main() {
   group('Matcher', () {
     final indexer = IoFeatureFileAccessor();
@@ -13,22 +15,22 @@ void main() {
         expect(
           await indexer
               .listFiles(RegExp(r'test\\test_resources\\(.*).feature')),
-          [
+          PathPartMatcher([
             r'test\test_resources\a.feature',
             r'test\test_resources\subdir\b.feature',
             r'test\test_resources\subdir\c.feature',
-          ],
+          ]),
         );
       });
 
       test('lists files from subdirectory', () async {
         expect(
           await indexer
               .listFiles(RegExp(r'test\\test_resources\\subdir\\.*\.feature')),
-          [
+          PathPartMatcher([
             r'test\test_resources\subdir\b.feature',
             r'test\test_resources\subdir\c.feature',
-          ],
+          ]),
         );
       });
     });
@@ -37,20 +39,20 @@ void main() {
       test('lists all matching files', () async {
         expect(
           await indexer.listFiles(Glob('test/test_resources/**.feature')),
-          [
+          PathPartMatcher([
             r'test\test_resources\a.feature',
             r'test\test_resources\subdir\b.feature',
             r'test\test_resources\subdir\c.feature',
-          ],
+          ]),
         );
       });
 
       test('list all matching file without subdirectories', () async {
         expect(
           await indexer.listFiles(Glob('test/test_resources/*.feature')),
-          [
+          PathPartMatcher([
             r'test\test_resources\a.feature',
-          ],
+          ]),
         );
       });
     });
@@ -59,9 +61,9 @@ void main() {
       test('lists one specified file', () async {
         expect(
           await indexer.listFiles(r'test\test_resources\a.feature'),
-          [
+          PathPartMatcher([
             r'test\test_resources\a.feature',
-          ],
+          ]),
         );
       });
     });

diff --git a/test/io/path_part_matcher.dart b/test/io/path_part_matcher.dart
@@ -0,0 +1,33 @@
+import 'package:matcher/matcher.dart';
+
+class PathPartMatcher extends Matcher {
+  late final Iterable<String> relativePaths;
+  final description = StringDescription();
+
+  PathPartMatcher(this.relativePaths);
+
+  @override
+  Description describe(Description description) {
+    return description..add(description.toString());
+  }
+
+  @override
+  bool matches(dynamic absolutePaths, Map matchState) {
+    var match = true;
+
+    for (var absPath in (absolutePaths as Iterable<String>)) {
+      var internalMatch = false;
+
+      for (var relativePath in relativePaths) {
+        if (absPath.contains(relativePath)) {
+          internalMatch = true;
+          break;
+        }
+      }
+
+      match = match && internalMatch;
+    }
+
+    return match;
+  }
+}