Delete unnecessary IOException and JOBS_SETTINGS_FILE

jonx8 · Sep 9, 2023 · 2595a41 · 2595a41
1 parent 6124280
commit 2595a41
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 18 deletions.
diff --git a/src/main/java/ru/etu/petci/Main.java b/src/main/java/ru/etu/petci/Main.java
@@ -9,7 +9,6 @@
 import java.util.logging.Logger;
 
 public class Main {
-    public static final String JOBS_SETTINGS_FILE = "jobs.properties";
     private static final Logger LOGGER = Logger.getLogger(Main.class.getName());
 
     static {

diff --git a/src/main/java/ru/etu/petci/configuration/Configurator.java b/src/main/java/ru/etu/petci/configuration/Configurator.java
@@ -4,7 +4,6 @@
 import ru.etu.petci.jobs.Job;
 import ru.etu.petci.observers.RepositoryObserver;
 
-import java.io.IOException;
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
@@ -37,7 +36,7 @@ public void saveRepositoryConfig(String repoPath, String branchName) {
     }
 
 
-    public List<Job> readJobsConfig() throws IOException, BackingStoreException {
+    public List<Job> readJobsConfig() throws BackingStoreException {
         List<Job> jobsList = new ArrayList<>();
         var jobsPreferences = Preferences.userRoot().node(JOBS_PREFERENCES);
         for (String jobName : jobsPreferences.keys()) {
@@ -48,7 +47,7 @@ public List<Job> readJobsConfig() throws IOException, BackingStoreException {
     }
 
 
-    public void saveJobsConfig(String jobName, String scriptPath) throws IOException {
+    public void saveJobsConfig(String jobName, String scriptPath) {
         var jobsPreferences = Preferences.userRoot().node(JOBS_PREFERENCES);
 
         if (jobsPreferences.get(jobName, null) == null) {

diff --git a/src/main/java/ru/etu/petci/handlers/AddCommandHandler.java b/src/main/java/ru/etu/petci/handlers/AddCommandHandler.java
@@ -2,7 +2,6 @@
 
 import ru.etu.petci.configuration.Configurator;
 
-import java.io.IOException;
 import java.util.Scanner;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -35,14 +34,8 @@ public int handle(String arg) {
             return 1;
         }
 
+        configurator.saveJobsConfig(jobName, scriptPath);
         scanner.close();
-
-        try {
-            configurator.saveJobsConfig(jobName, scriptPath);
-        } catch (IOException e) {
-            LOGGER.severe(e.getMessage());
-            return 1;
-        }
         return 0;
     }
 }
diff --git a/src/main/java/ru/etu/petci/handlers/ContinueCommandHandler.java b/src/main/java/ru/etu/petci/handlers/ContinueCommandHandler.java
@@ -7,7 +7,6 @@
 import ru.etu.petci.jobs.JobsExecutor;
 import ru.etu.petci.observers.RepositoryObserver;
 
-import java.io.IOException;
 import java.util.List;
 import java.util.Objects;
 import java.util.logging.Level;
@@ -35,7 +34,7 @@ public int handle(String arg) {
         } catch (InterruptedException e) {
             LOGGER.log(Level.SEVERE, "The program was interrupted");
             Thread.currentThread().interrupt();
-        } catch (RepositoryNotFoundException | BackingStoreException | IOException e) {
+        } catch (RepositoryNotFoundException | BackingStoreException e) {
             LOGGER.log(Level.SEVERE, e.getMessage());
         }
         return 1;

diff --git a/src/main/java/ru/etu/petci/handlers/InitCommandHandler.java b/src/main/java/ru/etu/petci/handlers/InitCommandHandler.java
@@ -2,15 +2,11 @@
 
 import ru.etu.petci.configuration.Configurator;
 
-import java.io.IOException;
-import java.nio.file.Path;
 import java.util.Objects;
 import java.util.Scanner;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import static ru.etu.petci.Main.JOBS_SETTINGS_FILE;
-
 public class InitCommandHandler implements CommandHandler {
     private static final Logger LOGGER = Logger.getLogger(InitCommandHandler.class.getName());