Ignore zero addresses in CLUSTER SLOTS response #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g7r
approved these changes
Sep 18, 2024
| host, hasHost := rawaddr[0].([]byte) | ||
| port, hasPort := rawaddr[1].(int64) | ||
| if !hasHost && hasPort && port == 0 { | ||
| // fallback to skip zero address |
There was a problem hiding this comment.
Let's leave a message explaining the source of this fallback:
Due to possible Redis cluster misconfiguration we can receive zero address for one of the replicas.
It is totally fine to skip the misconfigured replica and go with the remaining ones without inducing denial of service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip CLUSTER SLOTS elements if address is empty and port is zero.
Also, added happy-path test for CLUSTER SLOTS