[imp] Move editor-readmore overridable code to layout. Fixes #44. Fixes #10

layouts/plugins/editors-xtd/readmore/default.php

@@ -0,0 +1,35 @@
+<?php
+/**
+ * @package     Joomla.Site
+ * @subpackage  Layout
+ *
+ * @copyright   Copyright (C) 2005 - 2014 Open Source Matters, Inc. All rights reserved.
+ * @license     GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+defined('JPATH_BASE') or die;
+
+extract($displayData);
+
+/**
+ * Layout variables
+ * ---------------------
+ * 	$getContent      : (string) The content being passed to the plugin
+ * 	$present         : (string) Alert message
+ */
+
+$script = "
+	function insertReadmore(editor)
+	{
+		var content = $getContent
+		if (content.match(/<hr\s+id=(\"|')system-readmore(\"|')\s*\/*>/i))
+		{
+			alert('$present');
+			return false;
+		} else {
+			jInsertEditorText('<hr id=\"system-readmore\" />', editor);
+		}
+	}
+";
+
+JFactory::getDocument()->addScriptDeclaration($script);

plugins/editors-xtd/readmore/readmore.php

@@ -35,27 +35,16 @@ class PlgButtonReadmore extends JPlugin
 	 */
 	public function onDisplay($name)
 	{
-		$doc = JFactory::getDocument();
-
 		// Button is not active in specific content components
-
 		$getContent = $this->_subject->getContent($name);
 		$present = JText::_('PLG_READMORE_ALREADY_EXISTS', true);
-		$js = "
-			function insertReadmore(editor)
-			{
-				var content = $getContent
-				if (content.match(/<hr\s+id=(\"|')system-readmore(\"|')\s*\/*>/i))
-				{
-					alert('$present');
-					return false;
-				} else {
-					jInsertEditorText('<hr id=\"system-readmore\" />', editor);
-				}
-			}
-			";
 
-		$doc->addScriptDeclaration($js);
+		$this->getRenderer('default')->render(
+			array(
+				'getContent' => $getContent,
+				'present'    => $present
+			)
+		);
 
 		$button = new JObject;
 		$button->modal = false;