Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SEO tab #1

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Create SEO tab #1

wants to merge 4 commits into from

Conversation

alisha-kamat
Copy link
Collaborator

Summary of Changes

  • Make a separate SEO tab under the Article Edit section and include all the related SEO options for users (currently only placeholders have been created for this)
  • This new feature will assist developers to structure, maintain and extend the current functionality as the SEO requirements evolve
  • Right now this feature has been added only on the administration section. It can be added on the frontend after discussion with mentors.

image

Testing Instructions

  • Login from the backend and move over to the Article Edit section for any article. The SEO tab will be visible.
  • Try to edit an article after logging in from the frontend. SEO tab will not be visible.

Actual result BEFORE applying this Pull Request

  • The SEO tab should not be present on the Article Edit section

Expected result AFTER applying this Pull Request

  • The new SEO tab should be present with placeholders for Article Review, Page Performance, Paragraph Structure and Outgoing Link-checker

@bembelimen bembelimen changed the base branch from 4.0-dev to dev June 13, 2022 11:20
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Fixes Table User for Date/Date.php warning on login …
aae1bb8 
…(#36804)

Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] fixes all modules Deprecated: htmlspecialchars(): Pa…
e02d637 
…ssing null to type string (#36795)

* [3.10] [PHP 8.1] fixes mod_tags_popular

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`

* [3.10] [PHP 8.1] fixes mod_breadcrumbs

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`

* Update mod_custom.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

* [3.10] [PHP 8.1] Fixes mod_menu.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

* [3.10] [PHP 8.1] mod_stats

* [3.10] [PHP 8.1] fixes mod_articles_archive.php

* [3.10] [PHP 8.1] mod_articles_categories.php

* [3.10] [PHP 8.1] fixes mod_articles_category

* [3.10] [PHP 8.1] fixes mod_articles_latest

* [3.10] [PHP 8.1] fixes mod_articles_news

* [3.10] [PHP 8.1] fixes mod_articles_popular

* [3.10] [PHP 8.1] fixes mod_banners

* [3.10] [PHP 8.1] fixes mod_feed

* [3.10] [PHP 8.1] fixes mod_footer

* [3.10] [PHP 8.1] fixes mod_languages

* [3.10] [PHP 8.1] fixes mod_random_image

* [3.10] [PHP 8.1] fixes mod_related_items

* [3.10] [PHP 8.1] fixes mod_syndicate

* [3.10] [PHP 8.1] fixes mod_tags_similar

* [3.10] [PHP 8.1] fixes mod_users_latest

* [3.10] [PHP 8.1] fixes mod_whosonline

* [3.10] [PHP 8.1] fixes mod_wrapper

* [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard

* [3.10] [PHP 8.1] fixes admin mod_feed

* [3.10] [PHP 8.1] fixes admin mod_stats_admin
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compa…
61396f7 
…tible (#36794)

* [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)

* [3.10] [PHP 8.1] Fixes protostar modules.php null string param

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`

* [3.10] [PHP 8.1] Fixes beez modules.php null string param

Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Fixing mod_search Passing null to type string (#36792)
c0286f0 
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Fixes Table User for Date/Date.php warning on login …
d19bbe0 
…(#36799)

Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
Update BaseController.php (#36797)
3de1ce1 
Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286`
and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat @zero-24
[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 (#36777)
b90fb91 
* [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

* [PHP 8.1] Editor in backend: Better fix for #36777

Co-authored-by: Tobias Zulauf <[email protected]>

Co-authored-by: Tobias Zulauf <[email protected]>
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string …
0a1c48f 
…(#36773)

* [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string

Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383`

* [PHP 8.1] admin mod_menu: Slightly cleaner fix for #36773
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[3.10] [PHP 8.1] Fixes com_finder/indexer/query (#36796)
5ed8cdd 
* [3.10] [PHP 8.1] Fixes com_finder/indexer/query

Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733`

* Better fix for #36796 as suggested by @zero-24
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat @zero-24
[3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in …
e712ad7 
…strpos() (#36798)

* [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos()

Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124`

* [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24

Co-authored-by: Tobias Zulauf <[email protected]>

* Revert previous commit for different fix in mod_breadcrumbs/helper.php

* [PHP 8.1] Better fix for #36798 mod_breadcrumbs with null link in last item

Co-authored-by: Tobias Zulauf <[email protected]>
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
[PHP 8.1] Fix Deprecated notice: strtolower(): Passing null to string…
03c0fc6 
… is deprecated in components/com_ajax/ajax.php on line 39 (#37007)

Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
PHP 8.1: Fixes Deprecated: null to string in MailTemplate.php (#37384)
9d13d22 
Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"
bembelimen pushed a commit that referenced this pull request Jun 13, 2022
@beat
Fixes `Deprecated: strtolower(): Passing null to string in libraries/…
761e52e 
…src/Log/Log.php on line 387` (#37009)

Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisha-kamat @bembelimen