improve bump script #3368
improve bump script #3368
Conversation
tecpromotion
requested review from
a team,
zero-24 and
heelc29
and removed request for
a team
|
|
||
| if ($updated) { | ||
| file_put_contents($filePath, $contents); | ||
| echo "Copyright updated: $filePath" . PHP_EOL; |
There was a problem hiding this comment.
I'm not sure whether its worth writing out any change? Maybe its worth adding an "-v" option to show such logging but ignore it in most cases?
| $updated = true; | ||
| } | ||
|
|
||
| if (preg_match('#2008\s+-\s+[0-9]{4}\s+J\!German#', $contents)) { |
There was a problem hiding this comment.
Please help me but to me it looks like we will always go into this right? Is is possible somehow to check whether that year is != the current year first?
| $relativePath = str_replace($rootPath, '', $filePath); | ||
|
|
||
| // Skip excluded files and directories | ||
| if (preg_match('#\.(png|jpeg|jpg|gif|bmp|ico|webp|svg|woff|woff2|ttf|eot)$#', $filePath) || in_array($relativePath, $excludeFiles)) { |
There was a problem hiding this comment.
I do get the idea here but wouldn't it be easier to list only the extensions to include rather than the extensions to exclude?
There was a problem hiding this comment.
This was taken from the original, but of course it should be adapted!
|
Left comments looks good on a local test beyond that, but I think we should check that copyright and exclude/include extension thing. |
Zusammenfassung der Änderungen
First there was just the idea of passing the date with the -d option. And then after a few iterations, this came out.
Please test this locally and give me feedback.