minor fixes in rehack/runtime/js #6
Conversation
|
|
||
| let joo_global_object = global; |
There was a problem hiding this comment.
This file is generated by doing esy test in the root. There's a file at rehack_tests/templates/common-js-runtime-header.js which determines the output of esy test which needs to be changed to regenerate this.
| @@ -1 +1 @@ | |||
| module.exports = require('String.js'); | |||
| module.exports = require('./String.js'); | |||
There was a problem hiding this comment.
How do you know the String.js will be here?
The buildTest.sh file has some examples of how to actually run the examples when compiled separately. For example:
NODE_PATH="${PWD}/rehack_tests/strings/:${PWD}/rehack_tests/stdlib/stdlib.js:${PWD}/runtime/rehack/js/" node -e 'require("Strings")'
Which puts the stdlib and other libraries in the node search path so that require('String.js') would be resolved correctly. But I'm not so sure require('./String.js') will work as accurately because it demands that String_.js be in the same dir as String.js. That would be fine if we had a system that copied these into the stdlib or something. We definitely need better tools for that.
Feel free to come up with a good proposal/implementation. I really don't know what is best.
List_.jsrequirestatements