Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved usage information #119

Merged
merged 8 commits into from
Jan 2, 2025
Merged

Conversation

gytic
Copy link
Contributor

@gytic gytic commented Nov 11, 2024

I wrote some mini-tutorials about how to get started using lazysql as described in #117

To be more precise i wrote 'tutorials' for:

  • Connecting to a DB
  • Creating a table (redirect to SQL Editor)
  • Execute SQL querys
  • Open / View a table
  • Filter rows
  • Insert rows
  • Edit a column

I would love to know what you think about the phrasing, the general style and if you would want me to change.

@gytic gytic marked this pull request as draft November 11, 2024 21:10
@gytic gytic marked this pull request as ready for review November 11, 2024 21:14
@jorgerojas26
Copy link
Owner

I really like this. I'll just take a deeper look tomorrow and come back with suggestions, or maybe a merge.

Thank you for the PR.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gytic
Copy link
Contributor Author

gytic commented Nov 25, 2024

PR is ready for review

@jorgerojas26
Copy link
Owner

Hi, any progress on this?

@gytic
Copy link
Contributor Author

gytic commented Dec 26, 2024

I think it should be ready for review

@jorgerojas26
Copy link
Owner

There are some pending reviewed changes above, please read them. Also, please can you fix the merge conflict?

@gytic
Copy link
Contributor Author

gytic commented Dec 26, 2024

Merge conflicts are now resolved.

The one not-outdated comment got resolved in this commit, but some lines below, so i guess it is not detected.

(Or which comment do you mean?)

@jorgerojas26 jorgerojas26 merged commit c8d061a into jorgerojas26:main Jan 2, 2025
2 checks passed
@gytic gytic deleted the usage-info branch January 9, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants