Remove contentUserData bugfix and refactor #31

fix error: php.CRITICAL: Uncaught Error: Call to undefined method Doctrine\Bundle\DoctrineBundle\Registry::remove() inject $entityManager instead of $container
jorisdugue · May 5, 2021 · e9edc37 · e9edc37
2 parents b9de957 + 096cdb6
commit e9edc37
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 19 deletions.
diff --git a/Resources/config/services.yml b/Resources/config/services.yml
@@ -78,7 +78,7 @@ services:
 
     studit_h5p.result_storage:
         class: Studit\H5PBundle\Service\ResultService
-        arguments: ['@service_container']
+        arguments: ['@doctrine.orm.entity_manager']
     Studit\H5PBundle\Service\ResultService: '@studit_h5p.result_storage'
 
     Studit\H5PBundle\Command\H5pBundleIncludeAssetsCommand:

diff --git a/Service/ResultService.php b/Service/ResultService.php
@@ -5,24 +5,22 @@
 
 
 use Doctrine\ORM\EntityManagerInterface;
-use Psr\Container\ContainerInterface;
 use Studit\H5PBundle\Entity\ContentResult;
 use Symfony\Component\HttpFoundation\Request;
 
 class ResultService
 {
     /**
-     * @var ContainerInterface
+     * @var EntityManagerInterface
      */
-    private $container;
+    private $em;
 
     /**
      * ResultService constructor.
-     * @param ContainerInterface $container
      */
-    public function __construct(ContainerInterface $container)
+    public function __construct(EntityManagerInterface $em)
     {
-        $this->container = $container;
+        $this->em = $em;
     }
 
     /**
@@ -37,8 +35,8 @@ public function handleRequestFinished(Request $request, $userId)
             \H5PCore::ajaxError('Invalid content');
         }
         // TODO: Fire 'h5p_alter_user_result' event here.
-        $contentRepo = $this->container->get('doctrine')->getRepository('StuditH5PBundle:Content');
-        $contentResultRepo = $this->container->get('doctrine')->getRepository('StuditH5PBundle:ContentResult');
+        $contentRepo = $this->em->getRepository('StuditH5PBundle:Content');
+        $contentResultRepo = $this->em->getRepository('StuditH5PBundle:ContentResult');
         $result = $contentResultRepo->findOneBy(['userId' => $userId, 'content' => $contentId]);
         if (!$result) {
             $result = new ContentResult($userId);
@@ -61,11 +59,7 @@ public function handleRequestFinished(Request $request, $userId)
      */
     public function removeData($contentId, $dataType, $user, $subContentId)
     {
-        /**
-         * @var $em EntityManagerInterface
-         */
-        $em = $this->container->get('doctrine');
-        $ContenUserData = $em->getRepository('StuditH5PBundle:ContentUserData')
+        $ContentUserData = $this->em->getRepository('StuditH5PBundle:ContentUserData')
             ->findBy(
                 [
                     'subContentId' => $subContentId,
@@ -74,11 +68,11 @@ public function removeData($contentId, $dataType, $user, $subContentId)
                     'user' => $user->getId()
                 ]
             );
-        if (count($ContenUserData) > 0){
-            foreach ($ContenUserData as $content){
-                $em->remove($content);
+        if (count($ContentUserData) > 0){
+            foreach ($ContentUserData as $content){
+                $this->em->remove($content);
             }
-            $em->flush();
+            $this->em->flush();
         }
     }
-}
+}