Fix typos and improve test names

Co-authored-by: Morten Brekkevold <[email protected]>

python/nav/ipdevpoll/plugins/paloaltoarp.py

@@ -93,7 +93,7 @@ def _get_paloalto_arp_mappings(self, address: IP, key: str):
 
     @defer.inlineCallbacks
     def _do_request(self, address: IP, key: str):
-        """Make a HTTP request to Paloalto device"""
+        """Make an HTTP request to a Palo Alto device"""
 
         class SslPolicy(client.BrowserLikePolicyForHTTPS):
             def creatorForNetloc(self, hostname, port):

tests/unittests/ipdevpoll/plugins_paloaltoarp_test.py

@@ -54,7 +54,7 @@
     '''
 
 
-def test_should_correctly_parse_valid_http_response_body():
+def test_parse_arp_should_correctly_parse_valid_http_response_body():
     assert _parse_arp(valid_http_response_body) == [
         ('ifindex', IP('192.168.0.1'), '00:00:00:00:00:01'),
         ('ifindex', IP('192.168.0.2'), '00:00:00:00:00:02'),
@@ -64,7 +64,7 @@ def test_should_correctly_parse_valid_http_response_body():
 
 @pytest.mark.twisted
 @pytest_twisted.inlineCallbacks
-def test_should_return_arp_mappings_on_valid_http_response(paloaltoarp):
+def test_get_paloalto_arp_mappings_should_return_arp_mappings_on_valid_http_response(paloaltoarp):
     with patch.object(
         PaloaltoArp, "_do_request", return_value=defer.succeed(valid_http_response_body)
     ):
@@ -82,7 +82,7 @@ def test_should_return_arp_mappings_on_valid_http_response(paloaltoarp):
 
 @pytest.mark.twisted
 @pytest_twisted.inlineCallbacks
-def test_should_return_empty_list_on_request_error(paloaltoarp):
+def test_get_paloalto_arp_mappings_should_return_empty_list_on_request_error(paloaltoarp):
     with patch.object(PaloaltoArp, "_do_request", return_value=defer.succeed(None)):
         mappings = yield paloaltoarp._get_paloalto_arp_mappings(
             IP("10.0.0.0"), "incorrect_key"
@@ -92,7 +92,7 @@ def test_should_return_empty_list_on_request_error(paloaltoarp):
 
 @pytest.mark.twisted
 @pytest_twisted.inlineCallbacks
-def test_should_form_correct_api_query_url(paloaltoarp):
+def test_do_request_should_form_correct_api_query_url(paloaltoarp):
     mock_response = Mock(spec=Response)
     mock_agent = Mock(spec=Agent)
     mock_agent.request.return_value = defer.succeed(mock_response)