feat: remove 1pass for bot secrets

joryirving · Feb 3, 2025 · 3262a25 · 3262a25
1 parent 18a0698
commit 3262a25
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 41 deletions.
diff --git a/.github/workflows/label-sync.yaml b/.github/workflows/label-sync.yaml
@@ -18,25 +18,12 @@ jobs:
     name: Label Sync
     runs-on: ubuntu-latest
     steps:
-      - name: Configure 1password
-        uses: 1password/load-secrets-action/configure@v2
-        with:
-          service-account-token: ${{ secrets.ONEPASS_SA_TOKEN }}
-
-      - name: Get Secrets
-        uses: 1password/load-secrets-action@v2
-        with:
-          export-env: true
-        env:
-          BOT_APP_ID: op://Kubernetes/github-bot/BOT_APP_ID
-          BOT_APP_PRIVATE_KEY: op://Kubernetes/github-bot/BOT_APP_PRIVATE_KEY
-
       - name: Generate Token
         uses: actions/create-github-app-token@v1
         id: app-token
         with:
-          app-id: ${{ env.BOT_APP_ID }}
-          private-key: ${{ env.BOT_APP_PRIVATE_KEY }}
+          app-id: ${{ secrets.BOT_APP_ID }}
+          private-key: ${{ secrets.BOT_APP_PRIVATE_KEY }}
 
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/render-readme.yaml b/.github/workflows/render-readme.yaml
@@ -14,25 +14,12 @@ jobs:
     name: Render README
     runs-on: ubuntu-latest
     steps:
-      - name: Configure 1password
-        uses: 1password/load-secrets-action/configure@v2
-        with:
-          service-account-token: ${{ secrets.ONEPASS_SA_TOKEN }}
-
-      - name: Get Secrets
-        uses: 1password/load-secrets-action@v2
-        with:
-          export-env: true
-        env:
-          BOT_APP_ID: op://Kubernetes/github-bot/BOT_APP_ID
-          BOT_APP_PRIVATE_KEY: op://Kubernetes/github-bot/BOT_APP_PRIVATE_KEY
-
       - name: Generate Token
         uses: actions/create-github-app-token@v1
         id: app-token
         with:
-          app-id: ${{ env.BOT_APP_ID }}
-          private-key: ${{ env.BOT_APP_PRIVATE_KEY }}
+          app-id: ${{ secrets.BOT_APP_ID }}
+          private-key: ${{ secrets.BOT_APP_PRIVATE_KEY }}
 
       - name: Checkout
         uses: actions/checkout@v4

diff --git a/.github/workflows/scheduled-cleanup.yaml b/.github/workflows/scheduled-cleanup.yaml
@@ -14,21 +14,12 @@
       name: Cleanup untagged images
       runs-on: ubuntu-latest
       steps:
-        - name: Get Secrets
-          uses: 1password/load-secrets-action@v2
-          with:
-            export-env: true
-          env:
-            OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.ONEPASS_SA_TOKEN }}
-            BOT_APP_ID: op://Kubernetes/github-bot/BOT_APP_ID
-            BOT_APP_PRIVATE_KEY: op://Kubernetes/github-bot/BOT_APP_PRIVATE_KEY
-
         - name: Generate Token
           uses: actions/create-github-app-token@v1
           id: app-token
           with:
-            app-id: ${{ env.BOT_APP_ID }}
-            private-key: ${{ env.BOT_APP_PRIVATE_KEY }}
+            app-id: ${{ secrets.BOT_APP_ID }}
+            private-key: ${{ secrets.BOT_APP_PRIVATE_KEY }}
 
         - name: Set up Docker Buildx
           uses: docker/setup-buildx-action@v3