Help greenkeeper to manage lockfiles #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure, what are our options in this regard? To me the package-lock.json file is something that's just there to make sure that when you or I install dependencies at some point after checking out the latest version of a branch or some specific tag or commit, that we get installed the exact same versions of all dependencies. We can update the package-lock.json file as often as we want/need. @harrysarson your PR looks good to me, can you merge this PR and the related greenkeeper PR's? |
harrysarson
commented
Jul 27, 2018
|
Once we clarify the versions for npm install in #1189 (review) I will merge 👍 |
|
👍 |
harrysarson
added a commit
that referenced
this pull request
Sep 13, 2018
Greenkeep now has 'native' lockfile support, so this reverts changes in #1189. https://blog.greenkeeper.io/announcing-native-lockfile-support-85381a37a0d0
Merged
josdejong
pushed a commit
that referenced
this pull request
Sep 13, 2018
* Remove green-keeper lockfile. Greenkeep now has 'native' lockfile support, so this reverts changes in #1189. https://blog.greenkeeper.io/announcing-native-lockfile-support-85381a37a0d0 * Name travis jobs properly Based on: https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues we are having with greenkeeper,
npm ci, and lock files.Solution based on https://github.com/greenkeeperio/greenkeeper-lockfile#npm.
Should prevent CI failures in greenkeeper's PR #1183.
Greenkeeper issue: greenkeeperio/greenkeeper-lockfile#156.
@josdejong How tight should we be on the npm and greenkeeper-lock file versions?