-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue#444 and vetlog_master.sql #454
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your effort @Rasta341 , but it needs work.
@@ -227,3 +222,17 @@ CREATE TABLE `pet_medicine` ( | |||
KEY `FKnf9loskcjkxo9f2qafq08dyjm` (`pet_medicine_id`), | |||
CONSTRAINT `FKnf9loskcjkxo9f2qafq08dyjm` FOREIGN KEY (`pet_medicine_id`) REFERENCES `pet` (`id`) | |||
) ENGINE=InnoDB DEFAULT CHARSET=latin1; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flyway works with a concept named migrations, the main advantage of doing this is to create a database evolution from the very first version to the current version. You do not need to create new tables in the V1_vetlog_master.sql
since this is the first migration. You can know more about Flyway here: https://www.baeldung.com/database-migrations-with-flyway
@@ -21,7 +21,7 @@ | |||
"homepage": "https://github.com/josdem/servizi-dog-template#readme", | |||
"dependencies": { | |||
"jquery": "^3.6.0", | |||
"bootstrap": "~3.3.7", | |||
"bootstrap": "~5.3", | |||
"font-awesome": "~4.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating boostrap version to the latest is the easy part, however we need to make sure it is compatible with the template we are using: servizi-dog-theme, as you can
see the template is broken with this version:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i'm doing something wrong, but template looks same even with previous version (3.3.7) of bootstrap, when i deploy project locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i'm doing something wrong, but template looks same even with previous version (3.3.7) of bootstrap, when i deploy project locally
I see, try to run this command: npm install
from this directory: ${PROJECT_HOME}/src/main/resources/static/assets/servizi-dog-theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, try to run this command:
npm install
from this directory:${PROJECT_HOME}/src/main/resources/static/assets/servizi-dog-theme
thats work, thanks!
updated bootstrap version to 5.3
added missing fields/table in the script