Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#444 and vetlog_master.sql #454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Rasta341
Copy link

@Rasta341 Rasta341 commented Jan 6, 2025

updated bootstrap version to 5.3
added missing fields/table in the script

@josdem josdem self-requested a review January 6, 2025 22:23
Copy link
Owner

@josdem josdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your effort @Rasta341 , but it needs work.

@@ -227,3 +222,17 @@ CREATE TABLE `pet_medicine` (
KEY `FKnf9loskcjkxo9f2qafq08dyjm` (`pet_medicine_id`),
CONSTRAINT `FKnf9loskcjkxo9f2qafq08dyjm` FOREIGN KEY (`pet_medicine_id`) REFERENCES `pet` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flyway works with a concept named migrations, the main advantage of doing this is to create a database evolution from the very first version to the current version. You do not need to create new tables in the V1_vetlog_master.sql since this is the first migration. You can know more about Flyway here: https://www.baeldung.com/database-migrations-with-flyway

@@ -21,7 +21,7 @@
"homepage": "https://github.com/josdem/servizi-dog-template#readme",
"dependencies": {
"jquery": "^3.6.0",
"bootstrap": "~3.3.7",
"bootstrap": "~5.3",
"font-awesome": "~4.1.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating boostrap version to the latest is the easy part, however we need to make sure it is compatible with the template we are using: servizi-dog-theme, as you can
see the template is broken with this version: vetlog

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i'm doing something wrong, but template looks same even with previous version (3.3.7) of bootstrap, when i deploy project locally

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i'm doing something wrong, but template looks same even with previous version (3.3.7) of bootstrap, when i deploy project locally

I see, try to run this command: npm install from this directory: ${PROJECT_HOME}/src/main/resources/static/assets/servizi-dog-theme

Copy link
Author

@Rasta341 Rasta341 Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, try to run this command: npm install from this directory: ${PROJECT_HOME}/src/main/resources/static/assets/servizi-dog-theme

thats work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants