Proposal of some changes in the code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of the repository is legible (HTML and CSS). The sections are clearly differentiated including the header, navigation, main and footer. The design of the weboage is esthetic, I really liked how the content is shown and the colors have a good contrast. The navigation is consistent and is easy to go through the content of the webpage. However, I suggest a change in the responsiveness. Even though the webpage is responsive the section of "Who I am" could change its structure for medium devices having just two cards per row. The CSS rules are named consistently with their objective. I suggested some corrections in the code for the use of the tag br and indented the code using Prettier.
Here are some pictures of the validator:
