Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significant code refactoring + Reorganizing project structure + Multiple streams support + RTMP client implementation #66

Merged
merged 83 commits into from
Oct 2, 2024
Merged

Significant code refactoring + Reorganizing project structure + Multiple streams support + RTMP client implementation #66

merged 83 commits into from
Oct 2, 2024

Conversation

josephnhtam
Copy link
Owner

@josephnhtam josephnhtam commented Sep 29, 2024 •
edited
Loading

Summary

This pull request refactors the codebase, reorganizes namespaces, and introduces RTMP client implementation.

  • Added support for multiple streams per connection to enhance streaming capabilities.
  • Renamed interfaces and classes (e.g., IClient to ISession, IClientHandler to ISessionHandler).
  • Introduced the LiveStreamingServerNet.Networking.Client project to provide TCP client implementation.
  • Introduced LiveStreamingServerNet.Networking.Client and LiveStreamingServerNet.Rtmp.Client to provide RTMP client implementation.
  • Bug fixes

Breaking Changes

  • IClient is now ISession.
  • IClientInfo is now ISessionInfo.
  • IClientControl is now ISessionControl.
  • IClientHandler is now ISessionHandler.
  • Any code referencing the old names will need to be updated to the new names.
  • IServerEventHandler is moved to LiveStreamingServerNet.Networking.Server.Contracts.
  • Old contracts in LiveStreamingServerNet.Rtmp.Contracts are moved to LiveStreamingServerNet.Rtmp.Server.Contracts.

@josephnhtam
refactor: networking
71bae8a
@josephnhtam
feat: add Networking.Client
822cc40
@josephnhtam
refactor: rtmp
8a63e86
@josephnhtam
feat: improve simple handshake
021b5b4
@josephnhtam
feat: add rtmp client
77b290a
@josephnhtam
refactor: rename RtmpProtocolControlMessageSenderService to RtmpProto…
c75e738 
…colControlService
@josephnhtam
feat: parameters should be optional
19764cc
@josephnhtam
refactor: rtmp
be7457d
@josephnhtam
feat: ignore setPeerBandwidth protocol control
473b1a9
@josephnhtam
feat: change AppName in RtmpClientSessionContext to nullable string
ecfaec8
@josephnhtam
feat: add commander and message handlers
b3f930d
@josephnhtam
feat: expose message stream id for commands
c3f9e21
@josephnhtam
feat: add multi-stream support
dbba8ad
@josephnhtam
refactor: more consistent variable naming
0fd87ad
@josephnhtam
fix: stop publishing/subscribing should remove the corresponding context
46b7f29
@josephnhtam
fix: unit tests
d884732
@josephnhtam
refactor: move UpdateTimestamp to stream context
e64e45b
@josephnhtam
refactor: use ConcurrentDictionary instead
f65d3b5
@josephnhtam
fix: exception messages
8af9136
@josephnhtam
refactor: RtmpStreamContext
c31e1b2
@josephnhtam
refactor: rename RtmpStream to RtmpStreamContext
02131a6
@josephnhtam
feat: use lock-free approach to update timestamp
8d10174
@josephnhtam
refactor: rename RtmpStreamContextBase to RtmpMediaStreamContext
6766886
@josephnhtam
refactor: change IRtmpClientSessionContext to IAsyncDisposable
759b85b
@josephnhtam
refactor: change IRtmpClientSessionContext to IAsyncDisposable
72ad07a
@josephnhtam
feat: support multiple streams
e5f3cca
@josephnhtam
feat: improve rtmp client
c60f5e1
@josephnhtam
fix: stream metadata message
9deb674
@josephnhtam
feat: improve rtmp client
cf1e975
@josephnhtam
refactor: remove unused logging messages
015bf20
@josephnhtam josephnhtam changed the title Significant code refactoring + Reorganizing project structure + Multiple streams support + New RTMP client features. Significant code refactoring + Reorganizing project structure + Multiple streams support + RTMP client implementation Sep 30, 2024
@josephnhtam
fix: correct play unauthorized's status code
fa5e917
@josephnhtam
fix: typo
a17ef9f
@josephnhtam
chore: revise project descriptions
66b662c
@josephnhtam
feat: add package icon and readme
9f7bec8
@josephnhtam
chore: samples should not be packable
b9526d8
@josephnhtam
feat: improve user control messages
a461f3d
@josephnhtam
feat: expose command method to IRtmpClient, add user control message …
32a6a40 
…handling
@josephnhtam
chore: update project description
d572aa4
@josephnhtam
refactor: improve the encapsulation for rtmp command
899c310
@josephnhtam
feat: different chunk stream ids for different logical streams
a9e8805
@josephnhtam
fix: unit tests
a1616b8
@josephnhtam
fix: unit test
68c572b
@josephnhtam
chore: update docs
6690d32
@josephnhtam
feat: improve rtmp client
679a82d
@josephnhtam
feat: add publish support to rtmp client
2b80c3e
@josephnhtam
feat: improve rtmp client status
03f8d01
@josephnhtam
refactor: remove RtmpStreamDeletedException
1b106b9
@josephnhtam
refactor: simplify status
bc2cc7d
@josephnhtam
feat: improve RtmpClientStatus
1b903bc
@josephnhtam
refactor: improve encapsulation
03d275e
@josephnhtam
feat: add RtmpUrlParser
6d1190b
@josephnhtam
fix: flv tag header should support extended timestamp
a58f6ee
@josephnhtam
feat: add RtmpClient publish demo
0f2db0d
@josephnhtam
refactor: improve RtmpClientPublishDemo
d899e24
@josephnhtam
fix: rtmp client should be disposed
1612eb0
@josephnhtam
fix: dont change the discarding state when non-discardable message is…
d8222cb 
… encountered
@josephnhtam
feat: add event for bandwidth limit update
e3d2cb8
@josephnhtam josephnhtam merged commit 9e19282 into develop Oct 2, 2024
9 checks passed
@josephnhtam josephnhtam deleted the features/v0.15.0 branch October 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josephnhtam