Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: \pause can mess up tikzpictures #915

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

hmenke
Copy link
Contributor

@hmenke hmenke commented Oct 24, 2024

@samcarter samcarter merged commit 4e32cd1 into josephwright:main Oct 24, 2024
1 check passed
@samcarter
Copy link
Collaborator

@hmenke Thanks for the PR!

@josephwright
Copy link
Owner

I'm not so sure about this - TIll after all wrote both beamer and pgf and in general you can use \pause inside TikZ structures - the amsmath situation is very different.

@samcarter
Copy link
Collaborator

I'm not so sure about this - TIll after all wrote both beamer and pgf and in general you can use \pause inside TikZ structures - the amsmath situation is very different.

footlines etc. will vanish

@josephwright
Copy link
Owner

Sure but that's an edge case - you cannot use \pause in amsmath structures at all, really.

@samcarter
Copy link
Collaborator

@josephwright We could experiment with patching the end of the tikzpicture, e.g. \AtEndEnvironment{tikzpicture}{\onslide<1->} and see if it breaks something...

@samcarter
Copy link
Collaborator

samcarter commented Oct 24, 2024

I think the situation for amsmath is really similar to tikzpictures. Sometimes \pause might work, sometimes it might give wrong results.

E.g. a user might get away with something like

\documentclass{beamer}
\mode<presentation> { \setbeamercovered{transparent} }

\begin{document}
\begin{frame}
\begin{align}
  A &= B \\\pause
    &= C \\\pause
    &= D
\end{align}
\end{frame}
\end{document}

because they are lucky and happen to use the right uncover setting. They might also get away with using \pause in tikzpictures if they don't have a footline. But in general, \pause can cause problems.

@samcarter
Copy link
Collaborator

samcarter commented Oct 24, 2024

(@josephwright If you feel strongly about this, I'm fine with rolling back the commit. People will anyway keep trying to use it - the difference will just be if my answers on Q&A sites will be "don't use \pause" or "don't use \pause, see the doc" :) )

@hmenke hmenke deleted the pause branch October 24, 2024 09:59
@samcarter
Copy link
Collaborator

@josephwright Would you prefer if I would roll back the commit or do we keep it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants