Fix permalink sending #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 81460d2 added the sending of permalink to Akismet by adding it to the list of "default mappings" all of which get `comment_` prepended. However, according to the Askismet documentation[1], it appears that they expect `permalink` to be simply `permalink` and not `comment_permalink`. This commit fixes this discrepancy by moving the `:permalink` symbol from the list of attributes that receives the prepended `comment_` to the list of attributes that does not receive this prependage. [1]: http://akismet.com/development/api/#comment-check
When running this spec, rspec complained that `stub` is deprecated and that we should use `stub` instead. This commit does that.
|
Woh, you seem quite correct on this one. No idea why the Akismet guys didn't catch this when I had them looking over my requests! I'll try and get this one merged this week. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 81460d2 added the sending of permalink to Akismet by adding it to the list of "default mappings" all of which get
comment_prepended. However, according to the Askismet documentation1, it appears that they expectpermalinkto be simplypermalinkand notcomment_permalink.This commit fixes this discrepancy by moving the
:permalinksymbol from the list of attributes that receives the prependedcomment_to the list of attributes that does not receive this prependage.