chore: Make ratatui optional on tui-popups (Breaking / Help Wanted #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on ratatui-core types mainly except for the interaction with crossterm. This change is a bit breaking, as it requires the widget passed in to tui-popup to implement Clone. I can't find a clean way to replace this otherwise such that this call works: <https://github.com/joshka/tui-widgets/blob/83e45dbb31566ade6b323d05820c711561a1a46c/tui-popup/src/popup.rs#L147>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 73.34% 73.53% +0.18%
==========================================
Files 14 14
Lines 2465 2441 -24
==========================================
- Hits 1808 1795 -13
+ Misses 657 646 -11 ☔ View full report in Codecov by Sentry. |
joshka
commented
Nov 28, 2024
Comment on lines
-147
to
+123
| self.body.render_ref(inner_area, buf); | ||
| self.body.clone().render(inner_area, buf); |
There was a problem hiding this comment.
This one line is the crux of this entire change. I can't get this to work with &Widget, the best I can do is Clone the inner body widget. I'm not sure if this would be better left using WidgetRef instead of requiring Clone
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- Cargo.toml: Evaluated as low risk
joshka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on ratatui-core types mainly except for the interaction with
crossterm.
The goal here was to remove the reliance on the unstable WidgetRef
and StatefulWidgetRef traits, which are in Ratatui, and replace it with
the stable Widget/StatefulWidget traits in Ratatui-core.
I haven't found a way (yet) to make this work for &W: Widget instead of
W: Widget + Clone. Leaving this open a bit for anyone that wants to
give feedback on the change / explore whether this is possible to fix.
This is the call that needs to work (render the body widget of the popup.
tui-widgets/tui-popup/src/popup.rs
Line 147 in 83e45db