Update workflows #63
Open
Update workflows #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+21
to
+22
| - name: Yarn Test | ||
| run: yarn test --watchAll=false |
There was a problem hiding this comment.
Filed #64 because we don't have any react tests for this new workflow to run
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Install Dependencies | ||
| run: yarn |
There was a problem hiding this comment.
We're using npm. Will using yarn in our actions cause problems?
There was a problem hiding this comment.
Honestly, I have no idea. It seems to work, but 🤷 . We should probably hold off on this until we actually have unit tests in js too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What broke / What you're adding
Now that our React app is gonna be used more and more, I figured it's time to update our github workflows to reflect that.
How you did it
How to test it and how to try to break it
Notice that the golang nor react workflows don't run on this PR but the docker build image still doe