Feature: Conditional input interview transcript #62
Conversation
| @@ -0,0 +1,37 @@ | |||
| CREATE TABLE IF NOT EXISTS "analysis_feedback" ( | |||
| "id" text PRIMARY KEY NOT NULL, | |||
There was a problem hiding this comment.
Why primary key id is of type text?
| @@ -0,0 +1,37 @@ | |||
| CREATE TABLE IF NOT EXISTS "analysis_feedback" ( | |||
| "id" text PRIMARY KEY NOT NULL, | |||
| "user_id" text NOT NULL, | |||
There was a problem hiding this comment.
Why foreign key user_id is of type text?
| "user_id" text NOT NULL, | ||
| "analysis_id" uuid NOT NULL, | ||
| "is_found_useful" boolean NOT NULL, | ||
| "impact" text, |
There was a problem hiding this comment.
What's column 'impact' here?
Is this field where we store feedback messages? If yes please name it accordingly.
| "parsed_job_description" text, | ||
| "analysis_result" text, | ||
| "conversation" text, | ||
| "status" text, |
There was a problem hiding this comment.
Can we convert 'status' to enum?
| "analysis_result" text, | ||
| "conversation" text, | ||
| "status" text, | ||
| "created_at" timestamp DEFAULT now() |
There was a problem hiding this comment.
We're missing 'updated_at' column.
| <FormControl> | ||
| <Input | ||
| type="file" | ||
| accept=".txt,.docx,.pdf" |
There was a problem hiding this comment.
Does our code support reading from all these file types?
|
|
||
| def get_question_level_ratings(Asked_Questions): | ||
| try: | ||
| file_path = "/Users/sethupathiasokan/Documents/AiCruit/lingo.ai/Scorecard Template.xlsx" |
There was a problem hiding this comment.
Why is this hardcoded path there?
| def get_question_level_ratings(Asked_Questions): | ||
| try: | ||
| file_path = "/Users/sethupathiasokan/Documents/AiCruit/lingo.ai/Scorecard Template.xlsx" | ||
| sheet_name = "Java" |
There was a problem hiding this comment.
Is this still under development?
| # Perform transcription and speaker diarization | ||
| transcription_result = transcription_with_speaker_diarization(request) | ||
| transcript = transcription_result["transcript"] | ||
| questions_answers = transcription_result["qna"] |
There was a problem hiding this comment.
This if-else ladder can be optimized.
For example, This line is repeated 3 times:
questions_answers = transcription_result["qna"]
This method is called three times:
extract_conversation_from_file
There was a problem hiding this comment.
Need to rewrite the 'QNA_DIFFCULTY_LEVEL_RATING_FIND_PROMPT' prompt, as discussed.
Workdone is as follows -