Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Facets #9

wants to merge 1 commit into from

Conversation

konr
Copy link

@konr konr commented Mar 30, 2014

Hi!

I've upgraded the plugin to include facets in the interface. Here is a picture:

This was generated using the following configuration on the behaviors file:

 :editor [:lt.objs.editor/no-wrap
          (:lt.objs.style/set-theme "cobalt")
          (:lt.plugins.vim/activate-vim)
          (:lt.plugins.keymapper/set-facets!
           [{:name "etc" 
             :matchers [#"."]
             :display-order 0
             :eval-order 100}
            {:name "Known" 
             :matchers  [#":tabs" #":save" ]
             :display-order 1
             :hide true
             :eval-order 0}
            {:name "Bufferize"
             :matchers [#"bufferize"]
             :eval-order 2
             :display-order 2}])]

I plan to make the UI more interactive, while I learn about LT, but the basics are here.

@joshuafcole
Copy link
Owner

Sorry about the long wait! I've been on vacation with my family. I think in general this is a pretty feature to add to Keymapper.

A few questions off the top of my head:

  • Why did you choose to name the feature facets instead of something like "plugins" or "sources"?
  • I know keymapper doesn't currently pull the right data for getting info from the plugins themselves as they register, but wouldn't it be technically feasible to just tap into the registration like the describe-key plugin so we can automatically support all new plugins instead of needing to manually add regexps?

I'll get back to you with a full CR in a day or two.

Cheers,
Josh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants