Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging format contains process id and thread name also #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gccode1
Copy link

@gccode1 gccode1 commented Oct 3, 2018

It seems to be useful to add process id and thread name in logging. By using this we can distinguish between logging of different processes and different threads which is very useful in debugging.

@josiahcarlson
Copy link
Owner

I like where you are going with this (the ability to change / update the logging message format), but I can't change everyone's logging output going forward without explicitly letting them opt-in.

How are you calling rpqueue? I can probably pull information out of the system environment via os.environ, have a command-line argument --logfmt, or if you need this during load/import, I can probably push all of the logging initialization (and reading of log format config) until after the module has been loaded.

@josiahcarlson josiahcarlson added the more Need more information from OP label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more Need more information from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants