-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): extract redux extension logic into wrapper functions #38
refactor(utils): extract redux extension logic into wrapper functions #38
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3dcdf45:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, the refactoring looks okay.
src/utils/redux-extension/index.ts
Outdated
export * from './getReduxExtension'; | ||
export * from './createReduxConnection'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a preference of mine, but I'd avoid index
stuff.
Can you simply import them directly?
I am happy to help :)
Yes, I personally think you shouldn't merge #33. When unrendering a single
Actually no, that's not bug, it is the expected behavior. The extension itself owns all connections: When calling The only thing we could do is creating a feature request for disconnecting single connections, like I can create a issue for that and reference it 👍 Edit: Created an issue and mentioned it in #32 |
33c53e0
to
3dcdf45
Compare
It makes sense. I get the point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this is just refactoring without changing logic, it should be safe to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton again for your work!
Chunk of this PR: #32
This will create a redux devtools extension wrapper to make it easier to use and prevent the repetition of the code.
Furthermore adds some documentation and links for better DX.
It should not change any functionality but only do some refactoring.