Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge case on calling cleanup function #18

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

himself65
Copy link
Member

Fixes: #17

src/atomEffect.ts Outdated Show resolved Hide resolved
@himself65 himself65 force-pushed the himself65/fix-cleanup branch from 08aaf78 to 9629279 Compare November 9, 2023 01:59
@himself65 himself65 force-pushed the himself65/fix-cleanup branch from 9629279 to 6e25cff Compare November 9, 2023 02:23
@dmaskasky dmaskasky merged commit 3cb2b16 into jotaijs:main Nov 9, 2023
1 check passed
@himself65 himself65 deleted the himself65/fix-cleanup branch November 9, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup function not called in some edge cases
3 participants