fix: withImmer doesn't work with resettable atom
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tien
force-pushed
the
fix/with-immer-on-resettable-atom
branch
from
0478a8b to
aceb3e7
Compare
dai-shi
reviewed
Jun 23, 2024
tien
force-pushed
the
fix/with-immer-on-resettable-atom
branch
from
aceb3e7 to
99cd630
Compare
I believe it's like a switch case where the first matching pattern will be used, the original initial overload was too generic when I tested and ended up always shadowing the second overload. |
|
I was curious if the second pattern would ever match. |
dai-shi
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves pmndrs/jotai#2621