Skip to content

Commit

Permalink
Merge pull request #84 from jotaijs/kj/remove-wonka-improvements
Browse files Browse the repository at this point in the history
feat: remove wonka as a peer dependency, subscribe directly to QueryObserver
  • Loading branch information
kalijonn authored Aug 5, 2024
2 parents fae6e21 + faeb54c commit 2d12e85
Show file tree
Hide file tree
Showing 6 changed files with 5,780 additions and 4,715 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v4
with:
version: 8.2.0
version: 9
- uses: actions/setup-node@v3
with:
node-version: 18
registry-url: 'https://registry.npmjs.org'
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- run: npm test
- run: npm run compile
- run: npm publish
- run: pnpm test
- run: pnpm run compile
- run: pnpm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v4
with:
version: 8.2.0
version: 9
- uses: actions/setup-node@v3
with:
node-version: 18
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
- run: npm test
- run: pnpm test
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jotai-tanstack-query currently supports TanStack Query v5.

### Install

In addition to `jotai`, you have to install `jotai-tanstack-query`, `@tanstack/query-core` and `wonka` to use the extension.
In addition to `jotai`, you have to install `jotai-tanstack-query` and `@tanstack/query-core` to use the extension.

```bash
yarn add jotai-tanstack-query @tanstack/query-core wonka
yarn add jotai-tanstack-query @tanstack/query-core
```

### Incremental Adoption
Expand Down
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,10 @@
"typescript": "^5.2.2",
"webpack": "^5.88.2",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.1",
"wonka": "^6.3.4"
"webpack-dev-server": "^4.15.1"
},
"peerDependencies": {
"@tanstack/query-core": "*",
"jotai": ">=2.0.0",
"wonka": "^6.3.4"
"jotai": ">=2.0.0"
}
}
Loading

0 comments on commit 2d12e85

Please sign in to comment.