🐛 Fix missing skillId issue for async Alexa deploys #1617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Using the
--async
flag for alexa deploys callsgetImportStatus
right after deploying the skill. My testing showed that this leads to the response not being complete, see example:As you can see the result here only contained
status
, while theskill
property is not there. As Jovo is trying to accessstatus.skill.skillId
, this leads to the error in the screenshot.I found out that this seems to be dependent of the time passed since the import. Waiting a moment before requesting the import status fixes this issue, see this image that shows the

status
result:This is only relevant for
--async
deploys, due to non async deploys ignoreIN_PROGRESS
responses already.I was not sure whether to put this line of code before the
getImportStatus
call as it is now, or insidegetImportStatus
. I think it's a matter of preference, feel free to change or request changes if necessary.Types of Changes
Checklist