Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix missing skillId issue for async Alexa deploys #1617

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

Using the --async flag for alexa deploys calls getImportStatus right after deploying the skill. My testing showed that this leads to the response not being complete, see example:

image

As you can see the result here only contained status, while the skill property is not there. As Jovo is trying to access status.skill.skillId, this leads to the error in the screenshot.

I found out that this seems to be dependent of the time passed since the import. Waiting a moment before requesting the import status fixes this issue, see this image that shows the status result:
image

This is only relevant for --async deploys, due to non async deploys ignore IN_PROGRESS responses already.

I was not sure whether to put this line of code before the getImportStatus call as it is now, or inside getImportStatus. I think it's a matter of preference, feel free to change or request changes if necessary.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig jankoenig self-requested a review January 31, 2024 09:38
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sadlowskij!

@jankoenig jankoenig merged commit b7a6501 into jovotech:v4/dev Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants