Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add verify and certify commands to alexa cli plugin #1637

Merged

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This gives the developer an easy way to validate and certify their alexa skill by utilizing the information already present in the project configuration (like skillId, askProfile and so on). This is especially helpful if the project has many skills (we have one jovo app handling over 40 skills), where doing this manually is quite tedious.

I was not really sure about how to name this. The alexa cli so far has no commands, only hooks. If this is interesting to you, would this have to be platform independent, like jovo validate:platform alexa instead of how it is currently jovo validate:alexa?

If some of the information should be different, or the project config is not complete, there is the possibility to override those, however in the context of jovo, I think it will be most useful when it takes most information from jovo, e. g.

jovo certify:alexa --stage dev

I also included some documentation and heavily tested these two commands with all kinds of falg / configs, it seems to work great in my tests!

Please let me know, if you think this could be useful for Jovo!

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig jankoenig requested review from jankoenig and aswetlow May 30, 2024 14:44
@aswetlow
Copy link
Member

Wow, thank you!

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @sadlowskij!

@jankoenig jankoenig merged commit 347ab53 into jovotech:v4/dev Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants