Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add StartConnectionOutput for Alexa #1638

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This commit adds a convenient way to add skill connections, that have not already been covered by the multiple Output classes already provided. This is especially helpful, if you want to target a specific Task (e. g. in a specific skill), as the already provided output classes only covered predefined tasks.

The main new class added here is the StartConnectionOutput, which is a the most basic StartConnection Template, that should cover all types of StartConnection Directives the developer needs. Therefore I also refactored the already existing Outputs to use this more generic Output, to make these classes a bit more concise.

I tested the new class heavliy as well as made sure, that the refactored classes still work the same. In my tests, everything worked perfectly.

I also added documentation with links to the alexa developer documentation to explain how to use this new feature!

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@sadlowskij
Copy link
Contributor Author

In case this feature is interesting, but the refactoring of the old classes is not desired, I could also just revert the refactoring part and leave those classes as they were!

@jankoenig jankoenig self-requested a review June 6, 2024 13:30
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jankoenig jankoenig merged commit 7e3e4b3 into jovotech:v4/dev Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants