Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple usage for NLP package to ReadMe #114

Merged
merged 4 commits into from
Nov 4, 2023
Merged

Conversation

smty2018
Copy link
Contributor

Solves 1st job for issue #112

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d27bcb0) 61.23% compared to head (5015e03) 63.17%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   61.23%   63.17%   +1.94%     
==========================================
  Files           2        2              
  Lines         325      315      -10     
==========================================
  Hits          199      199              
+ Misses        126      116      -10     
Flag Coverage Δ
unittests 63.17% <ø> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smty2018
Copy link
Contributor Author

@joweich can you please review this PR?

Copy link
Owner

@joweich joweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smty2018 Only one minor comment 🙂 do you plan to address the other acceptance criteria of the issue in this PR as well?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jonas Weich <[email protected]>
@smty2018
Copy link
Contributor Author

smty2018 commented Oct 18, 2023

@smty2018 Only one minor comment 🙂 do you plan to address the other acceptance criteria of the issue in this PR as well?

I will work on the example results part and try to submit them in another separate PR for the examples by max tomorrow.

And really thank you for your guidance @joweich

@smty2018 smty2018 requested a review from joweich October 18, 2023 19:22
@joweich
Copy link
Owner

joweich commented Oct 18, 2023

@smty2018 Feel free to add the examples to this PR, we'll then have everything in the same place 👍

@smty2018
Copy link
Contributor Author

@smty2018 Feel free to add the examples to this PR, we'll then have everything in the same place 👍

okay, will commit to this branch only then.

@smty2018
Copy link
Contributor Author

@joweich added an example , can you please review it?

@joweich joweich merged commit ba7bb91 into joweich:main Nov 4, 2023
7 checks passed
@joweich
Copy link
Owner

joweich commented Nov 4, 2023

@smty2018 Thank you for your contribution and congrats to being on the main branch! 🚀 I only made some minor adjustments and merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants