-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple usage for NLP package to ReadMe #114
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 61.23% 63.17% +1.94%
==========================================
Files 2 2
Lines 325 315 -10
==========================================
Hits 199 199
+ Misses 126 116 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@joweich can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smty2018 Only one minor comment 🙂 do you plan to address the other acceptance criteria of the issue in this PR as well?
Co-authored-by: Jonas Weich <[email protected]>
@smty2018 Feel free to add the examples to this PR, we'll then have everything in the same place 👍 |
okay, will commit to this branch only then. |
@joweich added an example , can you please review it? |
@smty2018 Thank you for your contribution and congrats to being on the main branch! 🚀 I only made some minor adjustments and merged directly. |
Solves 1st job for issue #112