Upgrade to commonmarker v2 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossta
commented
Dec 8, 2024
| @@ -91,6 +91,8 @@ def visit(node) | |||
| html_inline(node.to_html(options: @options)) | |||
| in :strikethrough | |||
| s { visit_children(node) } | |||
| in :escaped | |||
| visit_children(node) | |||
There was a problem hiding this comment.
Commonmarker v2 adds this node type. In my debugging this node type in the test suite, this node wraps characters like "*" and "_", e.g.:
#<Commonmarker::Node(escaped): source_position={:start_line=>63, :start_column=>87, :end_line=>63, :end_column=>88} children=[#<Commonmarker::Node(text): source_position={:start_line=>63, :start_column=>87, :end_line=>63, :end_column=>88}, string_content="*">]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
rossta
force-pushed
the
chore/commonmarker-v2
branch
from
461fe46 to
6a68ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.