Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jmm models to list all tagged models #10

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

amisevsk
Copy link
Contributor

Rework how jmm models works to support changes from #8. Output now shows more information:

REPOSITORY   TAG      MAINTAINER   MODEL FORMAT   SIZE       DIGEST
<none>       <none>   gorkem       onnx           28.9 MiB   sha256:f95e7aadde0be84916ba01d91ad90aa13e46fb6084379629b17209d0133eefdd
testrepo     tag2     gorkem       onnx           28.9 MiB   sha256:f95e7aadde0be84916ba01d91ad90aa13e46fb6084379629b17209d0133eefdd
testrepo     tag1     gorkem       onnx           28.9 MiB   sha256:f95e7aadde0be84916ba01d91ad90aa13e46fb6084379629b17209d0133eefdd

Also fixes a bug (don't know where it got introduced) where model layers were being saved with a size of 0

* Rework jmm models to work with multiple local tags, rework output to
  show repo and tag first
* Fix bug where layers in manifest were not showing correct size
@amisevsk amisevsk requested a review from gorkem February 12, 2024 17:29
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorkem
Copy link
Contributor

gorkem commented Feb 12, 2024

It looks like the tests needs to be touched though

@amisevsk
Copy link
Contributor Author

Knew I was forgetting something.

@amisevsk amisevsk merged commit edc91be into main Feb 12, 2024
1 check passed
@amisevsk amisevsk deleted the list-all-tagged branch February 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants