Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Version Command to the CLI Tool #14

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add Version Command to the CLI Tool #14

merged 2 commits into from
Feb 13, 2024

Conversation

nida-hasan
Copy link
Contributor

Implement Version Command for JMM CLI

Overview

This PR introduces a version command to the JMM CLI tool, enabling users to retrieve the current version, Git commit, build time, and Go version used for the build. This addition aids in debugging and ensures version accuracy.

Changes

  • Added version.go under pkg/cmd/version with the version command implementation.
  • Updated the build script to inject version information at build time.
  • Registered the version command in cmd/root.go.

gorkem
gorkem approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gorkem gorkem merged commit daec660 into main Feb 13, 2024
1 check passed
@gorkem gorkem deleted the version-cmd branch February 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@gorkem gorkem gorkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nida-hasan @gorkem @amisevsk