Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up storage functionality; filter non-model artifacts in registries #19

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Clean up storage functionality; filter non-model artifacts in registries #19

merged 2 commits into from
Feb 15, 2024

Conversation

amisevsk
Copy link
Contributor

Description

  • Filter objects that are not jmm-created models from registries when pulling/listing. Previously, you could pull regular container images into the local store
  • Extract some common storage-related functionality to the storage package rather than duplicating it throughout other commands.

@amisevsk
Extract common functionality around local storage to package
2d38c99 
Move some common functionality around setting up local storage to the
storage package instead of copy-pasting it everywhere.
@amisevsk
Handle registries that contain other OCI artifacts
84f6d2a 
Update pull and models command to ignore OCI artifacts that are not
Models (e.g. container images)
gorkem
gorkem requested changes Feb 15, 2024
View reviewed changes
pkg/lib/storage/util.go Show resolved Hide resolved
@amisevsk amisevsk merged commit 4206e25 into main Feb 15, 2024
1 check passed
@amisevsk amisevsk deleted the rework-storage branch February 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amisevsk @gorkem