Rename cli to kit, package to kitops #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename module to kitops to match repo name; rename CLI to kit
gorkem
reviewed
Feb 21, 2024
pkg/lib/constants/consts.go
Outdated
| ModelConfigMediaType = "application/vnd.jozu.model.config.v1+json" | ||
| CodeLayerMediaType = "application/vnd.kitops.model.code.v1.tar+gzip" | ||
| // Media type for the model config (Kitfile) | ||
| ModelConfigMediaType = "application/vnd.kitops.model.config.v1+json" |
There was a problem hiding this comment.
Should we rename to application/vnd.kitops.kit.config.v1+json
There was a problem hiding this comment.
It depends -- what are we calling the packaged artifact we're producing? Is it a "model"/"kit"/"model kit"? I went with model since the command to list is still kit models and kit kits sounds awkward. Another option is kit modelkits, as well.
There was a problem hiding this comment.
The packaged artifact is model kit with a shorthand kit
There was a problem hiding this comment.
Alright, I've renamed "models" to "model kits" and "kit models" to "kit list".
Rename media types: application/vnd.kitops.modelkit.model.v1.tar+gzip -> model layer application/vnd.kitops.modelkit.dataset.v1.tar+gzip -> dataset layer application/vnd.kitops.modelkit.code.v1.tar+gzip -> code layer application/vnd.kitops.modelkit.config.v1+json -> config (Kitfile)
gorkem
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.