Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag command #52

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Add tag command #52

merged 1 commit into from
Feb 29, 2024

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Feb 28, 2024

Adds the tag command.

At this time it copies blobs between repository and registries.
Can not tag modelkits without an explicit repository using sha.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, though there's a bug:

❯ kit tag source:tag1 dest:tag1
Failed to tag modelkit: model localhost/dest:tag1 already exists in target registry
❯ kit list
REPOSITORY   TAG    MAINTAINER   NAME         SIZE    DIGEST
source       tag1   testing      Test-model   932 B   sha256:0ed7107f157f76fffd5f72552000c7308e618d57b1395f8df9ff9afc351834d7

pkg/cmd/tag/tag.go Outdated Show resolved Hide resolved
@gorkem gorkem merged commit 29b0f3e into main Feb 29, 2024
1 check passed
@gorkem gorkem deleted the add-tag-cmd branch February 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants