Handle file close in defer better for dev command #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
reviewed
Nov 27, 2024
pkg/lib/harness/llm_payload_all.go
Outdated
Comment on lines
122
to
130
| func deferCloseFile(f *os.File, err *error, msg string) { | ||
| defer func() { | ||
| if cerr := f.Close(); cerr != nil { | ||
| if *err == nil { | ||
| *err = fmt.Errorf("%s: %w", msg, cerr) | ||
| } else { | ||
| *err = fmt.Errorf("%v; %s: %w", *err, msg, cerr) | ||
| } | ||
| } | ||
| }() | ||
| } |
There was a problem hiding this comment.
I don't think this will work; the defer will execute when leaving the current scope, which is the called function (deferCloseFile)
There was a problem hiding this comment.
yeah, I should move the defer out. Dunno what I was thinking
Improve the handling of file close in defer by checking for possible errors during the close
amisevsk
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the handling of file close in defer by checking for errors during the close
fixes #625, #626