Normalize paths when deciding if files should be ignored #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we deal with cleaned paths when packing kitfile (i.e. normalizing './my-path', 'my-path/', etc. to just 'my-path', we need to do the same to kitfile fields when processing ignore files; otherwise we ignore files accidentally.
gorkem
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to normalize paths when computing ignores to ensure our current check succeeds in all cases. Currently, specifying a Kitfile such as
results in the ignore check asking "does path
my-modelhave prefixmy-model/?", which fails.To make sure we handle
./my-model,my-model/andmy-modelidentically, we clean paths in the ignore checker to match how Kitfile paths are handled elsewhereThis PR also adds a functional test that would fail on the current main branch but is fixed by the PR.
Linked issues
Closes #620