Rework storage to an interface; add tests for jmm models
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rework the artifact.Store struct into an interface with struct LocalStore implementing it to allow substitution during testing where I/O would be a hinderance * Hide the underlying storage from the struct, and force all interactions to go through the interface methods (i.e. no more store.Storage.Fetch()
Test that listing models works as expected and that bytes -> human readable format conversion produces expected results.
gorkem
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storeto its own package, introduce an interface to allow subbing out in testsStoretopkg/lib/testingjmm modelsslightly to allow testinglistModelsand coverage formodels.go