Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onnx export and validation for cms #378

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

erwulff
Copy link
Collaborator

@erwulff erwulff commented Nov 18, 2024

Update the SimpleMLPF model in the notebook for exporting and validating the ONNX model according to latest developments. Adresses #373 .

@erwulff
Copy link
Collaborator Author

erwulff commented Nov 19, 2024

CI / deps-torch fails with a "no space left on device" error when installing pip packages. I tried solving this by removing unnecessary software from the GitHub Actions runner in the CI / remove-unneeded-software job but that did not free up enough space. This error is unrelated to the changes made in this PR since the only thing that changed was the Jupyter notebook that exports and validates the ONNX model.

@erwulff erwulff added the CMS Concerns the CMS MLPF model label Nov 19, 2024
@erwulff
Copy link
Collaborator Author

erwulff commented Nov 19, 2024

PDF of the executed notebook: cms-validate-onnx.pdf
The notebook was executed using the checkpoint available here: jpata/particleflow v2.1.0

@jpata
Copy link
Owner

jpata commented Dec 2, 2024

Thank you! Will have to look into the CI space issue separately: #371

@jpata jpata merged commit f5c9aec into jpata:main Dec 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Concerns the CMS MLPF model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants