This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
For review: some more sample chat fixes #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 25, 2015 19:38
…ocketchat/fbptestwschat.js
jpaulm
added a commit
that referenced
this pull request
Aug 26, 2015
For review: some more sample chat fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, I really wanted the chat sample to help me understand FBP better in terms of how it can benefit large-scale web services. I do feel very fortunate that the web socket sample happened to come very close.
As I mentioned in #28, I am planning to work on a more functional multi-user chat project, both to help me continue learning how to work with FBP and as a use case that can motivate others to consider learning and adopting FBP.
Please keep in mind that this is the work of a real FBP beginner, that is why I didn't really get it right the first time.